[Codegen] extract emitDouble from parsers modules to shared parsers-primitives#34913
Closed
AntoineDoubovetzky wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: 54fc62c |
Base commit: 54fc62c |
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
AntoineDoubovetzky
force-pushed
the
refactor/extract-emitDouble-function
branch
from
496836d to
d96c443
Compare
Author
|
Rebased the branch because of conflicts |
rshest
approved these changes
Oct 10, 2022
Collaborator
|
This pull request was successfully merged by @AntoineDoubovetzky in 3ab7ef2. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #34872
This PR extracts the content of the case 'Double' (Flow, TypeScript) into a single emitDouble function in the parsers-primitives.js file. Use the new function in the parsers.
Changelog
[Internal] [Changed] - Extract contents of the case 'Double' into a single emitDouble function inside parsers-primitives
Test Plan
I tested using jest and flow commands.